Fix #122: Support non-ASCII characters in content gap analysis#156
Open
fazalpsinfo-cmyk wants to merge 2 commits into
Open
Fix #122: Support non-ASCII characters in content gap analysis#156fazalpsinfo-cmyk wants to merge 2 commits into
fazalpsinfo-cmyk wants to merge 2 commits into
Conversation
added 2 commits
July 15, 2026 14:28
The import at openagent_eval.providers.base.models does not exist; Document lives at openagent_eval.providers.models. Fixes OpenAgentHQ#80
…n to support non-ASCII
The regex r'\b[a-zA-Z]{4,}\b' only matches ASCII letters, so non-ASCII
characters (accented letters, CJK, emoji, etc.) were silently excluded
from content gap analysis. Changed to r'\b\w{4,}\b' which matches
Unicode word characters in Python 3.
Fixes OpenAgentHQ#122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Support non-ASCII characters in content gap analysis
Issue: #122 — Non-ASCII characters silently ignored in content gap keyword extraction.
Root cause:
re.findall(r"\b[a-zA-Z]{4,}\b", question)only matches ASCII letters. Accented characters, CJK, emoji, and other Unicode text are excluded from keyword extraction.Fix: Changed to
r"\b\w{4,}\b"which matches Unicode word characters in Python 3.Change: 1 line in
openagent_eval/diagnosis/chunking.py.If you found this fix useful, consider supporting the work at https://buymeacoffee.com/muhamedfazalps