Skip to content

Fix #122: Support non-ASCII characters in content gap analysis #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fazalpsinfo-cmyk wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix #122: Support non-ASCII characters in content gap analysis #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87b024b
Fix #80: Correct TYPE_CHECKING import path for Document
Jul 15, 2026
78c92a4
Fix #122: Use \w instead of [a-zA-Z] for keyword extraction to suppor…
Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openagent_eval/diagnosis/chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def _check_content_gaps(
"will", "about", "into", "your", "some", "than",
}
question_words = set(
w.lower() for w in re.findall(r"\b[a-zA-Z]{4,}\b", question)
w.lower() for w in re.findall(r"\b\w{4,}\b", question)
) - stop_words
if not question_words:
return issues
Expand Down
2 changes: 1 addition & 1 deletion openagent_eval/providers/base/retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from typing import TYPE_CHECKING

if TYPE_CHECKING:
from openagent_eval.providers.base.models import Document
from openagent_eval.providers.models import Document


class Retriever(ABC):
Expand Down
Loading