🏗️🔧：survive a failed call to the GitHub API - #1816
Merged
Merged
Conversation
Landing #1815 crashed once with a stack trace and worked on a second run, unchanged, which is what a transient 502 or a throttled request looks like from here. Reads are now tried twice; a merge is not, since repeating one that already reached GitHub would report the pull request as unmergeable when it had in fact just merged. Anything still unexpected reports a line rather than a stack trace. That needed the repository, the default branch and the actor to be worked out when first wanted instead of as the file loads, since nothing could catch them failing up there. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added
the
commit-queue
openinf-commit-queue
Bot
removed
the
commit-queue
|
The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/31862168870 — the label has been removed, so re-apply it once the reason is dealt with. |
The queue reports as a check like any other job, so requiring every check to have finished meant requiring itself to have finished, which it cannot do until it stops waiting. Labelling #1816 deadlocked on exactly that, which is what an end-to-end test is for. Its own run is identified by the run id in the check's details URL rather than by the job's name, so renaming the job cannot quietly reintroduce the deadlock. Every other run still counts, including another queue run on the same commit. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing #1815 crashed with a stack trace, then worked on a second run with nothing changed — which is what a transient 502 or a throttled request looks like from here. Now that the queue runs unattended on a label, that failure mode reaches somebody who did not type the command and cannot read the stack.
Reads are tried twice, a merge is not
A read that fails because GitHub hiccuped is not a reason to refuse to land, so
ghretries once. The merge itself deliberately does not: repeating one that had already reached GitHub would come back reporting the pull request as unmergeable, when in fact it had just been merged.Anything else says so in a line
rather than a Node stack trace.
Making that true meant working out the repository, the default branch and the actor when they are first wanted rather than as the file loads. They were computed at the top of the module, which runs before any
trycan cover it — so withghbroken, the guard I had just added was bypassed entirely. Verified by putting aghonPATHthat fails every time: before, a stack trace; now, the line above.Verification
nps test— 16/16 tasks, 63/63 testsghfailing on every call: one line, exit 1Note
This is the first pull request the commit queue can land, since #1815 put the workflow on
liveandpull_request_targettakes its workflow from the base branch. Applyingcommit-queuehere is the end-to-end test of the app, the token, both new guards, and whether the merge triggersdeploy.yml.