📖✨：say how a pull request reaches the history - #1817
Merged
Conversation
The handbook described the rules a message answers to without saying what happens to it afterwards. Labelling a pull request `commit-queue` squashes it into one commit whose body keeps every message it contained. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added
the
commit-queue
DerekNonGeneric
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handbook set out the rules a commit message answers to but never said what becomes of it. Labelling a pull request
commit-queuesquashes it into one commit whose body keeps every message it contained, with the trailers gathered where git reads them.Deliberately small: this is the first pull request the commit queue can land unaided. #1815 put the workflow on
live, #1816 fixed the deadlock where the queue waited for its own check to finish, andpull_request_targettakes both the workflow and the code it runs from the base branch — so neither of those could be landed by the queue itself.What this exercises: the app's token, the check that every other check has passed, the check that the labeller may push, the message composition, and whether the merge triggers
deploy.yml— which is why the queue holds an app's credentials rather thanGITHUB_TOKEN.