Skip to content

fix(app): Use filename and path to identify deleted file apollo cache updates - #4059

Merged
nellh merged 1 commit into
masterfrom
delete-cache-update-fix
Aug 11, 2026
Merged

fix(app): Use filename and path to identify deleted file apollo cache updates#4059
nellh merged 1 commit into
masterfrom
delete-cache-update-fix

Conversation

@nellh

@nellh nellh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

This fixes deletes appearing to not work on the client side. Reading by field instead of cache id matches correctly on the client side cache after the delete mutation succeed.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.90%. Comparing base (ead8d93) to head (606a331).

Files with missing lines Patch % Lines
...-app/src/scripts/dataset/mutations/delete-file.jsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4059   +/-   ##
=======================================
  Coverage   48.89%   48.90%           
=======================================
  Files         686      686           
  Lines       38075    38067    -8     
  Branches     1897     1897           
=======================================
- Hits        18616    18615    -1     
+ Misses      19295    19288    -7     
  Partials      164      164           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 129 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@openneuro/app-esm 16.07MB -129 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @openneuro/app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/dataset-*.js -129 bytes 389.41kB -0.03%

Files in assets/dataset-*.js:

  • ./src/scripts/dataset/mutations/delete-file.jsx → Total Size: 2.06kB

@nellh
nellh merged commit c15e707 into master Aug 11, 2026
17 of 18 checks passed
@nellh
nellh deleted the delete-cache-update-fix branch August 11, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant