Skip to content

fix(app): Use filename and path to identify deleted file apollo cache updates #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nellh merged 1 commit into from
Aug 11, 2026
+11 −26
Merged

fix(app): Use filename and path to identify deleted file apollo cache updates #4059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions packages/openneuro-app/src/scripts/dataset/mutations/delete-file.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,6 @@ const DELETE_FILE = gql`
}
`

const DELETED_FILE_FRAGMENT = gql`
fragment DeletedFile on DatasetFile {
id
key
filename
directory
}
`

/**
* Given a file object, path/filename for deletion, and a list of currently loaded files, filter any that will be deleted and orphan directories
*/
Expand Down Expand Up @@ -52,28 +43,22 @@ const DeleteFile = ({ datasetId, path, filename }) => {
cache.modify({
id: `Draft:${datasetId}`,
fields: {
files(cachedFiles) {
files(cachedFiles, { readField }) {
// DatasetFile is not normalized (keyFields: false) so read the
// fields we need via readField instead of cache ids
const cachedFileObjects = cachedFiles.map((f) => ({
filename: readField("filename", f),
directory: readField("directory", f),
}))
// Filter any removed files from the Draft.files cache
const cachedFileObjects = cachedFiles.map((f) =>
cache.readFragment({
id: cache.identify(f),
fragment: DELETED_FILE_FRAGMENT,
})
)
const remainingFiles = cachedFiles.filter((f) => {
// Get the cache key for each file we have loaded
const file = cache.readFragment({
id: cache.identify(f),
fragment: DELETED_FILE_FRAGMENT,
})
return fileCacheDeleteFilter(
file,
return cachedFiles.filter((_, index) =>
fileCacheDeleteFilter(
cachedFileObjects[index],
path,
filename,
cachedFileObjects,
)
})
return remainingFiles
)
},
},
})
Expand Down