Open
Conversation
deleted-user-1
commented
Jan 10, 2021
| return $this->get_response("Error: No profile data"); | ||
| } | ||
|
|
||
| $avatar = [ |
Author
PhpBB's driver->get_data() method does not expose absolute URLs and we need special handling for every avatar type due to each using a different URL pattern. We therefore have to hardcode the avatar type name and path fragments and depend on internals with which we will need to maintain compatibility in case of future upstream changes. Using our own implementation with less overhead does not introduce further costs in this case.
deleted-user-1
force-pushed
the
refactor-avatars
branch
from
48bf342 to
58694d6
Compare
Open
dragunoff
approved these changes
Jan 16, 2021
Contributor
dragunoff
left a comment
dragunoff
left a comment
There was a problem hiding this comment.
LGTM and works on my localhost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhpBB's driver->get_data() method does not expose absolute URLs and
we need special handling for every avatar type due to each using a different URL pattern.
We therefore have to hardcode the avatar type name and path fragments and depend on
internals with which we will need to maintain compatibility in case of future upstream changes.
Using our own implementation with less overhead does not introduce further costs in this case.
I have tested this locally with all avatar types (gallery, file upload, upload from url, remote, gravatar) including customized image sizes and with legacy integer
user_avatar_type.Notes:
'core.get_gravatar_url_after'is an event only for customization and not used by phpBB internally, so we do not need this until we want to modify gravatars.