Open
Conversation
PhpBB's driver->get_data() method does not expose absolute URLs and we need special handling for every avatar type due to each using a different URL pattern. We therefore have to hardcode the avatar type name and path fragments and depend on internals with which we will need to maintain compatibility in case of future upstream changes. Using our own implementation with less overhead does not introduce further costs in this case.
We are not using the special built-in '_format' parameter because we need to set the response headers anyway manually for the default 'MiniYAML' format. See https://symfony.com/doc/2.8/routing.html#routing-format-param for Symfony's special '_format' parameter.
This was referenced Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #50. It makes more sense to have the format placeholder at the end of the routes to take an optional argument. By this we keep the option to utilize the
{type}placeholder for future API routes.Depends on #52.
You can review and test by commit by commit.