Add Gen6 FOC vs MPC simulation study - #31
Open
saeed95-lab wants to merge 39 commits into
Open
Conversation
Introduce Lib/Simulation (dq plant, eight-state VSI, MPCC/FOC runners and tests), the control.mpcc graph template, and docs/scripts so predictive current control can be verified on host before STM32 PWM adapter work.
- Add Assets/Examples/mpcc_demo.json: full FCS-MPCC hardware graph with phase currents, encoder, DC-link, FRAM config params, and telemetry. - Add Transforms.SwitchToDuty node: maps switch states (0/1) to 0%/100% duty for the existing Actuators.PwmOut. - Add Values.Config/constructor.cpp: restore platform_config_load() call that was dropped when config.value was renamed to Values.Config. - Fix control.mpcc: correct angular-velocity unit to au::radians/au::seconds, add port/parameter descriptions. - Fix CodeGenerator: treat Values.Config as a config node.
Conventional FCS picks S111 on low-L motors because one full vector predicts ~1000 A per step; Mode 3 applies deadbeat voltage through SVPWM so duties are continuous and Iq can track.
Bypass IqGate and stop CfgEnable from forcing ThrottleEnable off. Mode 3 now uses a shorter Ts_Eff plus residual current integrators so low-L deadbeat voltages are not lost to inverter deadtime.
…m/saeed95-lab/RTE into feature/fcs-mpcc-three-phase-pmsm
Reload Values.Config from FRAM in TimIsrStart, guard Poles<=0 in ElecAngle, and trip Mode 3 voltage when measured current exceeds I_Max.
Replace aggressive Ts_Eff/Ki and hard overcurrent trip with FOC-like gains, voltage LPF, soft current foldback, and wire L/Rs/Psi from FRAM.
…m/saeed95-lab/RTE into feature/fcs-mpcc-three-phase-pmsm
Sanitize Ld/Lq when Config is 0, restore Config.Value on control start, guard EncoderSign≈0, and add mpcc_ld/lq/sign/theta_mech telemetry.
SelfExecutablePath used Linux-only /proc/self/exe; add Apple support and still fall back to PATH when needed.
Unwrap θe derivative spikes, clamp Ωe feedforward, persist non-zero motor/encoder FRAM defaults, harden OC latch, and detune Mode 3 gains.
Raise Mode 3 gains, set I_Max=40 with a higher OC latch threshold, and slow Iq slew for Gen6 bring-up.
Hard OC latch and aggressive gains locked the rotor with huge current; Config repair also treated Sign=-1 as missing and forced +1. Co-authored-by: Cursor <cursoragent@cursor.com>
Session 215141 pinned duties near 50% via an rs-based stall cap (~2 V with Rs≈0.012 Ω) and iq tracked opposite IqVar; match FOC gains/limits and flip q-axis error polarity. Co-authored-by: Cursor <cursoragent@cursor.com>
…m/saeed95-lab/RTE into feature/fcs-mpcc-three-phase-pmsm
Session 220144 still had FRAM Sign=+1 (wrong θe, id ±40 A) and soft foldback that kept duties near 50%; wire Sign=-1 and raise L/Ts current gains. Co-authored-by: Cursor <cursoragent@cursor.com>
…emo) Main fixed the FOC current-dump regression (lost sensor sign inversion in the node-library overhaul) via a configurable InvertPolarity parameter. Port the same template here and enable it on the Currents node so the MPCC loop gets correctly-signed feedback.
Use deadbeat voltage→SVPWM without hard OC foldback, match FOC encoder Sign (+1/FRAM), and document the safe first-spin procedure. Co-authored-by: Cursor <cursoragent@cursor.com>
The graph's embedded Sensors.PhaseCurrents uses the InvertPolarity parameter (ported from main), but the node instance never set it, so codegen emitted no binding and the build failed with 'InvertPolarity was not declared in this scope'.
Lift ωe clamp to ±3000 rad/s, increase deadbeat gain scale to 0.70, and match FOC Iq slew (50 A/s) so 100 V high-speed runs are not starved. Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes optimal-duty FCS-MPCC for synchronous sim, adds bench-motor comparison runner/plots, and keeps this work separate from the prior hardware MPCC branch. Co-authored-by: Cursor <cursoragent@cursor.com>
Softens deadbeat/integral, adds Vdc guards and Iq clamps, retunes mpcc_demo limits/slew, and documents a 50 V quiet bring-up path. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
Smooth-spin MPCC update pushedHardened Mode 3 for quiet Gen6 bring-up (especially ~50 V):
Please reflash |
Rely on I_Max only, raise deadbeat slightly for 50 V tracking, and allow Iq commands up to 15 A in mpcc_demo. Co-authored-by: Cursor <cursoragent@cursor.com>
Add current LPF, clamp Id/Iq refs to I_Max, and prioritize Vq under saturation so mid-bus field-weakening spins more like FOC. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paper_foc_vs_mpcrunner, plot scripts, and sample results underresults/paper_foc_vs_mpc/.Lib/Simulation, MPCC modes, Gen6-related fixes).feature/fcs-mpcc-three-phase-pmsm). This branch adds the FOC vs MPC paper comparison on top of that work.Test plan
cmake -B build -G Ninja && cmake --build build -j8 --target paper_foc_vs_mpc./build/Lib/Simulation/paper_foc_vs_mpcwrites CSVs underresults/paper_foc_vs_mpc/python3 scripts/plot_paper_foc_vs_mpc.pyregenerates Case 1 / Case 2 plotsctest --test-dir build --output-on-failureif available in this tree