Use assistant role for prunable-tools injection#187
Merged
Conversation
Switch from user role to assistant role message for injecting prunable-tools context. This reduces the likelihood of the model directly addressing the injected content as if responding to user input, improving the conversational experience.
Reasoning models expect their encrypted reasoning parts in assistant messages, which we cannot generate. This adds detection via chat.params hook and appends a synthetic user message (<system-context-injection/>) to close the assistant turn properly when a reasoning model is active.
…nt messages - Nudge prompts now use 'I must/I will' instead of 'You must/You should' - Prunable tools wrapper and cooldown message use first-person - System prompts updated to correctly describe injection as assistant message
…olete injected_context_handling instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary