Fix Reconstructions on cuda#968
Merged
fzimmermann89 merged 18 commits intomainfrom Apr 16, 2026
Merged
Conversation
recalculate_csm used type(self)(...) to create a temporary reconstruction for CSM estimation, which failed for subclasses with required keyword-only arguments (RegularizedIterativeSENSEReconstruction, TotalVariationRegularizedReconstruction). Instead, add optional csm/noise override parameters to direct_reconstruction using the existing Literal[False] pattern, and call it directly from recalculate_csm with csm=False to skip coil combination.
Contributor
Contributor
📚 Documentation |
7ca75ca to
66edf1d
Compare
Member
Author
d9aac91 to
0cfef35
Compare
ckolbPTB
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces .csm and .dcf on the plug and play reconstructions by .csm_op and .dcf_op, respectifly
This is a quick fix for moving a reconstruction to cuda.
currently,
reco.cuda()would not move dcf/csm, and application to a cuda tensor fails.(..Alterntive would be implementing a custom .to that also moves dataclasses.... but i wont have time for that.)