Fix stat values for some Tree nodes when using Hulking Form#1414
Merged
Conversation
If Hulking form was allocated we were still scaling Notables by 1x and the gsub to scale the mod value would match multiple values in the line and replace them all with the scaled value e.g. 1% increased Damage per 15 Strength 1% would be scaled by 1x and then the gsub would replace both numbers in the line with 1 so it would become 1% increased Damage per 1 Strength
Member
|
Do any stats on the tree scale the second number instead? That could cause an issue here |
Contributor
Author
Heavy Drinker20% increased Life Recovery from Flasks I checked all the nodes on the tree and the only one I found was a Flask notable that is not in the range of any jewel sockets so can't scale anyway |
Wires77
approved these changes
Sep 18, 2025
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Probably fine for now, especially if this is only visual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Hulking form was allocated we were still scaling Notables by 1x and the gsub to scale the mod value would match multiple values in the line and replace them all with the scaled value
e.g. 1% increased Damage per 15 Strength
1% would be scaled by 1x and then the gsub would replace both numbers in the line with 1 so it would become
1% increased Damage per 1 Strength
Fixes #1413
Build:
https://maxroll.gg/poe2/pob/1c29d0gt
Before:
After:
