Fix Crash when hovering over some Tree nodes with Hulking Form allocated#1428
Merged
Conversation
Some mods use a table but don't have another mod nested inside the table like the code expects. e.g. + Gem level mods Some mods just a flag so instead of trying to identify if a mod is a flag, we only scale a line if the value returned is a number. That way `math.abs(newValue)` will always work Also found that scaling Notables would break when we had a explode mod line as we had the value key named `chance`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some mods use a table but don't have another mod nested inside the table like the code expects.
e.g. + Gem level mods
Some mods just a flag so instead of trying to identify if a mod is a flag, we only scale a line if the value returned is a number. That way
math.abs(newValue)will always workAlso found that scaling Notables would break when we had a explode mod line as we had the value key named
chanceFixes #1419