Fix occasional crash when hovering over breakdown while using Radius Jewels#1539
Merged
LocalIdentity merged 1 commit intoDec 14, 2025
Conversation
…has a "table" instead of a numeric value in the attribute value
raxkin
changed the title
raxkin
changed the title
LocalIdentity
approved these changes
Dec 14, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
Nice work with the PR
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1497, #817 .
Description of the problem being solved:
When parsing the mods of Time Lost jewels, some mods don't keep the source node, and when showing the breakdown it crashes because it can't find the source node.
This also should happen with other jewels that has the mod:
conquered (%w+) Passive Skills also grant (.*)$
This normally is handled fine on non jewel mods, but was missing on the radius mods.
This is how this mod looked like, where you can see that there is no source in
value.mod:Steps taken to verify a working solution:
For
^(%w+) Passive Skills in Radius also grant (.*)$andconquered (%w+) Passive Skills also grant (.*)$mods, ifmod.valueis of typetable, that means that it has a inner mod, so we add the source also thereLink to a build that showcases this PR:
https://pobb.in/cJPcSu2F-T47
Before screenshot:
After screenshot: