Skip to content

Fix occasional crash when hovering over breakdown while using Radius Jewels #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Dec 14, 2025
Merged

Fix occasional crash when hovering over breakdown while using Radius Jewels #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Modules/ModParser.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6517,25 +6517,31 @@ local jewelOtherFuncs = {
end
end
end,
["^(%w+) Passive Skills in Radius also grant (.*)$"] = function(type, mod)
["^(%w+) Passive Skills in Radius also grant (.*)$"] = function(passiveType, mod)
return function(node, out, data)
if node and (node.type == firstToUpper(type) or (node.type == "Normal" and not node.isAttribute and firstToUpper(type) == "Small")) then
if node and (node.type == firstToUpper(passiveType) or (node.type == "Normal" and not node.isAttribute and firstToUpper(passiveType) == "Small")) then
local modList, line = parseMod(mod)
if not line and modList[1] then -- something failed to parse, do not add to list
modList[1].parsedLine = capitalizeWordsInString(mod)
modList[1].source = data.modSource
if type(modList[1].value) == "table" and modList[1].value.mod then
modList[1].value.mod.source = data.modSource
end
out:AddMod(modList[1])
end
end
end
end,
["conquered (%w+) Passive Skills also grant (.*)$"] = function(type, mod)
["conquered (%w+) Passive Skills also grant (.*)$"] = function(passiveType, mod)
return function(node, out, data)
if node and (node.type == firstToUpper(type) or (node.type == "Normal" and not node.isAttribute and firstToUpper(type) == "Small") or (node.type == "Normal" and node.isAttribute and firstToUpper(type) == "Attribute")) then
if node and (node.type == firstToUpper(passiveType) or (node.type == "Normal" and not node.isAttribute and firstToUpper(passiveType) == "Small") or (node.type == "Normal" and node.isAttribute and firstToUpper(passiveType) == "Attribute")) then
local modList, line = parseMod(mod)
if not line and modList[1] then -- something failed to parse, do not add to list
modList[1].parsedLine = capitalizeWordsInString(mod)
modList[1].source = data.modSource
if type(modList[1].value) == "table" and modList[1].value.mod then
modList[1].value.mod.source = data.modSource
end
out:AddMod(modList[1])
end
end
Expand Down