Add new question type file#599
Closed
srobotta wants to merge 1 commit into
Closed
Conversation
7c2da17 to
4a26a1a
Compare
Contributor
|
Thank you for all the effort you have put into this. I will review this happily. |
4a26a1a to
1354804
Compare
Contributor
Author
|
Just rebased to the latest MOODLE_401_STABLE branch. |
1354804 to
6344bcd
Compare
mchurchward
requested changes
Feb 20, 2025
Contributor
mchurchward
left a comment
There was a problem hiding this comment.
I know this is old, but I was just testing it on MOODLE_404_STABLE and it didn't work.
I had a number of odd issues.
- If I saved a response instead of submitting, when I went to resume the questionnaire, my file was not in the file question.
- If I then uploaded it again, and submitted, I received the error "Undefined property: stdClass::$itemid" from the responsetype/file class when it went to delete the old response on line 136.
- When I did it again, and submitted the first time, it worked. But the response page showed me a question response to rate question from another questionnaire.
- I believe this will need backup and restore support code added?
Merged
Contributor
Author
|
This is obsolete as of PR #681. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mike,
this is a new pull request for the new file type question and replaces #559
The original work on the file type has been done by Laurent David (https://github.com/laurentdavid). He introduced this question/response type and also created #471
Luca Bösch added behat tests for the new file type.
I finally fixed a few issues from the original work from Laurent:
I have taken your latest MOODLE_401_STABLE branch from the plugin and our codebase from BFH where this is already included and created this pull request that just contains the file type.