Conversation
Twixes
force-pushed
the
gh-tweaks
branch
4 times, most recently
from
6632b4e to
8e41f7d
Compare
- Show Welcome pane instead of "warming up" when no GitHub integration exists - Add GitHub connection card to signal sources config modal - Disable signal source toggles until GitHub is connected - Fix redirect URL after GitHub OAuth (was 404ing with double-concatenated URL) - Make onboarding Connect GitHub button retryable during auth flow - Show GitHub profile pictures for suggested reviewers - Add github_login to available_reviewers API response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If you don't have a GitHub integration set up on your project, Inbox is basically useless — but we were still showing "Inbox is warming up..." which is confusing. Also the GitHub connection flow had a few papercuts (404 redirect after OAuth, no way to retry if you close the browser tab, etc).
Changes
Inbox gating on GitHub integration:
GitHub OAuth flow fixes:
nextredirect URL — was double-concatenating the full cloud URL, causing a 404/integration-connectedpage (needs corresponding posthog/posthog PR) instead of a project pageSuggested reviewer avatars:
github_loginto theavailable_reviewersAPI response (needs corresponding posthog/posthog PR)How did you test this?
pnpm --filter code typecheckpassespnpm --filter code test— all 649 tests pass