Skip to content

fix: Prevent auto-generated title from overwriting manual rename#1676

Open
charlesvien wants to merge 3 commits into04-15-add_task_search_and_sidebar_context_menu_integration_to_command_centerfrom
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
Open

fix: Prevent auto-generated title from overwriting manual rename#1676
charlesvien wants to merge 3 commits into04-15-add_task_search_and_sidebar_context_menu_integration_to_command_centerfrom
04-15-prevent_auto-generated_title_from_overwriting_manual_rename

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 15, 2026

Problem

Auto-title generation silently bypassed the title_manually_set guard because getQueryData used exact key matching while task queries include filter objects in their keys.

Closes #1669

Changes

  1. Fix cache lookup in useChatTitleGenerator to use getQueriesData (prefix match) instead of getQueryData (exact match)
  2. Add title_manually_set guard to generateTaskTitle at task creation time

How did you test this?

Manually

@charlesvien charlesvien changed the title Prevent auto-generated title from overwriting manual rename fix: Prevent auto-generated title from overwriting manual rename Apr 15, 2026
Copy link
Copy Markdown
Member Author

charlesvien commented Apr 15, 2026

@charlesvien charlesvien force-pushed the 04-15-prevent_auto-generated_title_from_overwriting_manual_rename branch from 90ebf0c to 94a8ce6 Compare April 15, 2026 21:01
@charlesvien charlesvien marked this pull request as ready for review April 15, 2026 21:03
@charlesvien charlesvien force-pushed the 04-15-add_task_search_and_sidebar_context_menu_integration_to_command_center branch from 000d5bb to e96a20f Compare April 15, 2026 21:25
@charlesvien charlesvien force-pushed the 04-15-prevent_auto-generated_title_from_overwriting_manual_rename branch from 94a8ce6 to 3124ffd Compare April 15, 2026 21:25
@charlesvien charlesvien force-pushed the 04-15-prevent_auto-generated_title_from_overwriting_manual_rename branch from 3124ffd to 2b53d3c Compare April 15, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant