Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
import type { Task } from "@shared/types";
import { generateTitleAndSummary } from "@utils/generateTitle";
import { logger } from "@utils/logger";
import { queryClient } from "@utils/queryClient";
import { getCachedTask, queryClient } from "@utils/queryClient";
import { extractUserPromptsFromEvents } from "@utils/session";
import { useEffect, useRef } from "react";

Expand Down Expand Up @@ -65,17 +65,14 @@ export function useChatTitleGenerator(taskId: string): void {

const run = async () => {
try {
const cachedTasks = queryClient.getQueryData<Task[]>(["tasks", "list"]);
const cachedTask = cachedTasks?.find((t) => t.id === taskId);
if (cachedTask?.title_manually_set) {
log.debug("Skipping auto-title, user renamed task", { taskId });
return;
}

const result = await generateTitleAndSummary(content);
if (result) {
const { title, summary } = result;
if (title) {
if (getCachedTask(taskId)?.title_manually_set) {
log.debug("Skipping auto-title, user renamed task", { taskId });
return;
}
const client = await getAuthenticatedClient();
if (client) {
await client.updateTask(taskId, { title });
Expand Down
78 changes: 77 additions & 1 deletion apps/code/src/renderer/sagas/task/task-creation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const mockWorkspaceDelete = vi.hoisted(() => vi.fn());
const mockGetTaskDirectory = vi.hoisted(() => vi.fn());
const mockReadAbsoluteFile = vi.hoisted(() => vi.fn());
const mockReadFileAsBase64 = vi.hoisted(() => vi.fn());
const mockGetCachedTask = vi.hoisted(() => vi.fn());

vi.mock("@renderer/trpc", () => ({
trpcClient: {
Expand Down Expand Up @@ -52,14 +53,16 @@ vi.mock("@features/sessions/service/service", () => ({
}),
}));

const mockGenerateTitleAndSummary = vi.hoisted(() => vi.fn());
vi.mock("@renderer/utils/generateTitle", () => ({
generateTitleAndSummary: vi.fn(async () => null),
generateTitleAndSummary: mockGenerateTitleAndSummary,
}));

vi.mock("@utils/queryClient", () => ({
queryClient: {
setQueriesData: vi.fn(),
},
getCachedTask: mockGetCachedTask,
}));

vi.mock("@utils/logger", () => ({
Expand Down Expand Up @@ -179,6 +182,79 @@ describe("TaskCreationSaga", () => {
);
});

it("skips auto-title when task has been manually renamed", async () => {
const createdTask = createTask();
const startedTask = createTask({ latest_run: createRun() });
const createTaskMock = vi.fn().mockResolvedValue(createdTask);
const runTaskInCloudMock = vi.fn().mockResolvedValue(startedTask);
const updateTaskMock = vi.fn();

mockGenerateTitleAndSummary.mockResolvedValue({ title: "Auto title" });
mockGetCachedTask.mockReturnValue({
id: "task-123",
title_manually_set: true,
});

const saga = new TaskCreationSaga({
posthogClient: {
createTask: createTaskMock,
deleteTask: vi.fn(),
getTask: vi.fn(),
runTaskInCloud: runTaskInCloudMock,
sendRunCommand: vi.fn(),
updateTask: updateTaskMock,
} as never,
});

await saga.run({
content: "Ship the fix",
repository: "posthog/posthog",
workspaceMode: "cloud",
branch: "main",
});

await vi.waitFor(() => {
expect(mockGenerateTitleAndSummary).toHaveBeenCalled();
});

expect(updateTaskMock).not.toHaveBeenCalled();
});

it("applies auto-title when task has not been manually renamed", async () => {
const createdTask = createTask();
const startedTask = createTask({ latest_run: createRun() });
const createTaskMock = vi.fn().mockResolvedValue(createdTask);
const runTaskInCloudMock = vi.fn().mockResolvedValue(startedTask);
const updateTaskMock = vi.fn().mockResolvedValue(undefined);

mockGenerateTitleAndSummary.mockResolvedValue({ title: "Auto title" });
mockGetCachedTask.mockReturnValue(undefined);

const saga = new TaskCreationSaga({
posthogClient: {
createTask: createTaskMock,
deleteTask: vi.fn(),
getTask: vi.fn(),
runTaskInCloud: runTaskInCloudMock,
sendRunCommand: vi.fn(),
updateTask: updateTaskMock,
} as never,
});

await saga.run({
content: "Ship the fix",
repository: "posthog/posthog",
workspaceMode: "cloud",
branch: "main",
});

await vi.waitFor(() => {
expect(updateTaskMock).toHaveBeenCalledWith("task-123", {
title: "Auto title",
});
});
});

it("sends initial cloud prompts with attachments as pending user messages", async () => {
const createdTask = createTask();
const startedTask = createTask({ latest_run: createRun() });
Expand Down
7 changes: 6 additions & 1 deletion apps/code/src/renderer/sagas/task/task-creation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import type { ExecutionMode, Task } from "@shared/types";
import type { CloudRunSource, PrAuthorshipMode } from "@shared/types/cloud";
import { getGhUserTokenOrThrow } from "@utils/github";
import { logger } from "@utils/logger";
import { queryClient } from "@utils/queryClient";
import { getCachedTask, queryClient } from "@utils/queryClient";

const log = logger.scope("task-creation-saga");

Expand All @@ -39,6 +39,11 @@ async function generateTaskTitle(
if (!result?.title) return;
const { title } = result;

if (getCachedTask(taskId)?.title_manually_set) {
log.debug("Skipping auto-title, user renamed task", { taskId });
return;
}

try {
await posthogClient.updateTask(taskId, { title });

Expand Down
63 changes: 63 additions & 0 deletions apps/code/src/renderer/utils/queryClient.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
import type { Task } from "@shared/types";
import { beforeEach, describe, expect, it } from "vitest";
import { getCachedTask, queryClient } from "./queryClient";

const createTask = (overrides: Partial<Task> = {}): Task => ({
id: "task-1",
task_number: 1,
slug: "task-1",
title: "Test task",
description: "",
origin_product: "user_created",
repository: null,
created_at: "2026-04-15T00:00:00Z",
updated_at: "2026-04-15T00:00:00Z",
...overrides,
});

describe("getCachedTask", () => {
beforeEach(() => {
queryClient.clear();
});

it("returns matching task from cache", () => {
const tasks = [createTask({ id: "task-1" }), createTask({ id: "task-2" })];
queryClient.setQueryData(["tasks", "list"], tasks);

expect(getCachedTask("task-1")?.id).toBe("task-1");
expect(getCachedTask("task-2")?.id).toBe("task-2");
});

it("returns undefined when task is not in cache", () => {
queryClient.setQueryData(["tasks", "list"], [createTask({ id: "task-1" })]);

expect(getCachedTask("nonexistent")).toBeUndefined();
});

it("returns undefined when no task queries exist", () => {
expect(getCachedTask("task-1")).toBeUndefined();
});

it("searches across multiple task list queries", () => {
queryClient.setQueryData(
["tasks", "list", { folder: "a" }],
[createTask({ id: "task-a" })],
);
queryClient.setQueryData(
["tasks", "list", { folder: "b" }],
[createTask({ id: "task-b" })],
);

expect(getCachedTask("task-a")?.id).toBe("task-a");
expect(getCachedTask("task-b")?.id).toBe("task-b");
});

it("preserves title_manually_set flag", () => {
queryClient.setQueryData(
["tasks", "list"],
[createTask({ id: "task-1", title_manually_set: true })],
);

expect(getCachedTask("task-1")?.title_manually_set).toBe(true);
});
});
8 changes: 8 additions & 0 deletions apps/code/src/renderer/utils/queryClient.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { Task } from "@shared/types";
import { QueryClient } from "@tanstack/react-query";

export const queryClient = new QueryClient({
Expand All @@ -8,3 +9,10 @@ export const queryClient = new QueryClient({
},
},
});

export function getCachedTask(taskId: string): Task | undefined {
return queryClient
.getQueriesData<Task[]>({ queryKey: ["tasks", "list"] })
.flatMap(([, tasks]) => tasks ?? [])
.find((t) => t.id === taskId);
}
Loading