remove deprecated findFFTW that fails on runners#222
Merged
Conversation
Collaborator
Author
|
@landreman or @mbkumar, can you check this also works on Mac installs? I do not know the tricks to findFFTW there, or in which folders to hint. If you have more elegant solutions to circumvent findFFTW I am also all ears. |
Collaborator
Author
|
Merging because the CI must go on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the findFFTW hack has run its course, modern CMake is reasonably good at finding it, and the repo has not been updated in 4 years.
This is now causing simsopt CI to fail as findFFTW has a
cmake_minimum_required(VERSION 3.5.0)somewere, and newest runners with modern CMakes refuse to continue when they see that.Instead of patching this old workaround, and stack the hacks, I modified it to use normal CMake.
Because F2py is picky, I had to add a few extra hoops to resolve the full library path and name.