chore: add THIRD-PARTY-NOTICES.md for vendored sklearn-compat#294
Conversation
The single-file sklearn-compat compatibility shim at src/tabpfn_extensions/misc/sklearn_compat.py (vendored verbatim from upstream version 0.1.5) had only a "taken from URL" pointer with no license / copyright attribution. Adds: - THIRD-PARTY-NOTICES.md at repo root mirroring the format used in fomo-fitting and TabPFN. - BSD-3-Clause attribution block in the vendored file header (Copyright (c) 2024, Guillaume Lemaitre). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds proper third-party attribution for the vendored sklearn-compat code, addressing a missing license/copyright notice for ~1000 lines of BSD-3-Clause code.
Changes:
- New
THIRD-PARTY-NOTICES.mdat repo root with summary table and per-upstream attribution. - Expanded header in
sklearn_compat.pywith copyright, SPDX identifier, and license note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| THIRD-PARTY-NOTICES.md | New notices file documenting vendored sklearn-compat with BSD-3-Clause attribution and guidance for future entries. |
| src/tabpfn_extensions/misc/sklearn_compat.py | Replaces brief source pointer with full attribution block including copyright and SPDX license identifier. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new THIRD-PARTY-NOTICES.md file to document vendored third-party code and updates the header of src/tabpfn_extensions/misc/sklearn_compat.py to include proper attribution and license information. The review feedback suggests a minor wording improvement in the documentation to ensure consistency when referring to the notice file.
| When vendoring or adapting third-party code: | ||
|
|
||
| 1. Preserve any upstream per-file copyright and license header verbatim. If the upstream does not ship a per-file header, add an attribution block citing the upstream URL, copyright holder, and SPDX license identifier. | ||
| 2. When vendoring a whole directory of upstream code, also vendor the upstream `LICENSE` / `NOTICE` file alongside it. For single-file adaptations, the in-file attribution plus the entry in this NOTICE file is sufficient. |
There was a problem hiding this comment.
The file is named THIRD-PARTY-NOTICES.md. Referring to it as "this NOTICE file" is slightly inconsistent with the rest of the document (e.g., line 36 uses "this file") and might be confused with a separate NOTICE file. Using "this file" is clearer.
| 2. When vendoring a whole directory of upstream code, also vendor the upstream `LICENSE` / `NOTICE` file alongside it. For single-file adaptations, the in-file attribution plus the entry in this NOTICE file is sufficient. | |
| 2. When vendoring a whole directory of upstream code, also vendor the upstream LICENSE / NOTICE file alongside it. For single-file adaptations, the in-file attribution plus the entry in this file is sufficient. |
Summary
src/tabpfn_extensions/misc/sklearn_compat.pyis a verbatim vendoring of sklearn-compat 0.1.5 (~1000 lines), but only had a# taken from URLpointer and no license / copyright attribution.THIRD-PARTY-NOTICES.mdat repo root with a proper BSD-3-Clause attribution entry (matches the format used in fomo-fitting and TabPFN).Upstream license verified via the GitHub API.
Test plan
THIRD-PARTY-NOTICES.mdshows on repo landing page🤖 Generated with Claude Code