-
Notifications
You must be signed in to change notification settings - Fork 58
chore: add THIRD-PARTY-NOTICES.md for vendored sklearn-compat #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Third-Party Notices | ||
|
|
||
| This file documents third-party code adapted into this repository, with | ||
| upstream attribution preserved. Transitive dependencies installed via | ||
| `pip` are governed by their own licenses (see `pyproject.toml` for the | ||
| canonical list). | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| | Upstream | Local path | Upstream license | | ||
| |---|---|---| | ||
| | sklearn-compat — single-file compat shim | `src/tabpfn_extensions/misc/sklearn_compat.py` | BSD-3-Clause | | ||
|
|
||
| --- | ||
|
|
||
| ## Per-upstream notices | ||
|
|
||
| ### sklearn-compat — compatibility shim | ||
|
|
||
| **Upstream:** https://github.com/sklearn-compat/sklearn-compat | ||
| **Local path:** `src/tabpfn_extensions/misc/sklearn_compat.py` (single-file vendored distribution; ~1000 lines) | ||
| **License:** BSD-3-Clause | ||
| **Copyright:** Copyright (c) 2024, Guillaume Lemaitre (per the upstream `LICENSE`) | ||
| **Modifications:** None of significance; vendored verbatim from upstream version 0.1.5 to avoid an extra runtime dependency. The single-file format is the distribution model sklearn-compat itself encourages for downstream users. File is kept as close to upstream as possible — both `ruff` formatting and `mypy` type-checking are suppressed at the top of the file. | ||
|
|
||
| --- | ||
|
|
||
| ## Adding new entries | ||
|
|
||
| When vendoring or adapting third-party code: | ||
|
|
||
| 1. Preserve any upstream per-file copyright and license header verbatim. If the upstream does not ship a per-file header, add an attribution block citing the upstream URL, copyright holder, and SPDX license identifier. | ||
| 2. When vendoring a whole directory of upstream code, also vendor the upstream `LICENSE` / `NOTICE` file alongside it. For single-file adaptations, the in-file attribution plus the entry in this NOTICE file is sufficient. | ||
| 3. Add a row to the summary table and a per-upstream notice to this file, including the upstream copyright line when one is published. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is named
THIRD-PARTY-NOTICES.md. Referring to it as "this NOTICE file" is slightly inconsistent with the rest of the document (e.g., line 36 uses "this file") and might be confused with a separateNOTICEfile. Using "this file" is clearer.