docs: warn that settings_search.search_dict silently drops iterations_per_quick_update#67
Merged
Merged
Conversation
al_configure_search: SettingsSearch.search_dict is a fixed-key property, so assigning iterations_per_quick_update (or anything else) to it is a silent no-op and the value never reaches the search — the config default (often 1e99, never) wins. Document the correct idiom (pass directly to af.Nautilus, as autolens_workspace does) and the conf.instance workaround for pipeline-wide use. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HD3ZkpFRydshFLeu2V6xDi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsSearch.search_dictis a fixed-key property (path_prefix, unique_tag, number_of_cores, session, use_jax_vmap), sosearch_dict['iterations_per_quick_update'] = …is a silent no-op — the value never reaches the search and the config default (often1e99= never quick-update) wins. Documents the correct idiom (passiterations_per_quick_update=…directly toaf.Nautilus, asautolens_workspacedoes) and theconf.instanceworkaround.Found while debugging a real SLaM run that produced no on-the-fly output for 8h because of exactly this.
🤖 Generated with Claude Code