Simplification of updater CLI options#157
Merged
marmarek merged 8 commits intoJun 28, 2024
Merged
Conversation
piotrbartman
force-pushed
the
prb/updater_unify_restarting
branch
from
fdb6d4c to
cd36a0e
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
marmarek
approved these changes
Jun 26, 2024
marmarek
reviewed
Jun 26, 2024
| return max(ret_code_independent, ret_code_appvm, ret_code_restart) | ||
| ret_code = max(ret_code_independent, ret_code_appvm, ret_code_restart) | ||
| if ret_code == 0 and no_updates: | ||
| return 100 |
Member
There was a problem hiding this comment.
This could use some documentation. I'll update integration tests as several of them failed on this one...
On a second thought, is it really a good idea to exit non-zero if everything is up to date already? I realize it may be useful information for some wrapping tools, so maybe have this behavior behind some option?
BTW, this applies both to the case where update was run and there was nothing to install, and to the case where update was skipped based on some flags (like no updates-available flag, and user didn't forced an update).
marmarek
approved these changes
Jun 27, 2024
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062721-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests11 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 5 fixed
Unstable testsDetails
|
This was referenced Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring CLI arguments to avoid unintuitive updater behavior along with suitable tests.
Now, the selection of VMs for updating is based on two phases: preselection and selection.
Preselection is based on the passed flags and selects VMs for further selection (e.g., all templates and some standalones). During selection, the VMs chosen for updating are those from preselection for which in case of flag:
--update-id-available: we know that updates are available;--update-if-stale, we know that updates are available or the VMs haven't been checked for updates in a long time;--force-update, all from the preselection.TODO: