non interactive updater#199
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 93.20% 93.53% +0.32%
==========================================
Files 57 57
Lines 10601 10816 +215
==========================================
+ Hits 9881 10117 +236
+ Misses 720 699 -21 ☔ View full report in Codecov by Sentry. |
deeplow
left a comment
deeplow
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR and fantastic work! This non-interactive approach quite elegantly tackles all the outstanding issues I had filed.
The only other thing that stood out to me was that when using --apply-to-all the user gets two messages to acknowledge:
- ✔️ All qubes were restarted / shutdown successfully [OK]
- ✔️ All selected qubes have been updated [OK]
Any way these could be turned into one single message so the user doesn't have to acknowledge two prompts?
| '(default: %(default)d)', | ||
| type=int, default=default_update_if_stale) | ||
| update_state.add_argument( | ||
| '--update-if-available', action='store_true', |
There was a problem hiding this comment.
Passing this argument is erroring for me. I am running qubes-updater-gui --targets fedora-40-xfce --update-if-available but it's failing with a traceback and the following message:
qubes-vm-update: error: unrecognized arguments: --update-if-available
I think what's going on here is that the GUI in fact applying the necessary modification in the HeaderCheckbox, but it is still trying to pass that argument to qubes-vm-update instead of ignoring it.
There was a problem hiding this comment.
It's probably because you didn't update qubes-vm-update, see
"depends on QubesOS/qubes-core-admin-linux#157"
The PR is ready to install, only ci tests do not work.
piotrbartman
force-pushed
the
prb/non-interactive-updater
branch
from
98e1e61 to
fc9c6d4
Compare
piotrbartman
force-pushed
the
prb/non-interactive-updater
branch
from
5304009 to
15dc1f1
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062816-4.3&flavor=pull-requests Test run included the following:
Installing updates failed, skipping the report! |
4 participants
This PR is a general solution to several issues, particularly related to the use of CLI arguments.
It implements the return of non-zero codes when an update fails, is canceled, or when no new updates are available.
CLI arguments have been unified with the backend to make their usage easier.
The reason for this PR is distinguishing between situations when we can confirm that the system is fully updated and when it is only partially updated.
depends on QubesOS/qubes-core-admin-linux/pull/157
fixes QubesOS/qubes-issues#9014
fixes QubesOS/qubes-issues#9032
fixes QubesOS/qubes-issues#9225