Skip to content

Improve output of qvm-vm-update for not-to-update vms#216

Open
techge wants to merge 3 commits into
QubesOS:mainfrom
techge:techge-2606-fix-error-msg
Open

Improve output of qvm-vm-update for not-to-update vms#216
techge wants to merge 3 commits into
QubesOS:mainfrom
techge:techge-2606-fix-error-msg

Conversation

@techge

@techge techge commented Jun 18, 2026

Copy link
Copy Markdown

The first commit might be sufficient to fix the issue at hand, but the second makes it more clear.

Please let me know if I missed some common code quality details. First commit in a while...

Closes QubesOS/qubes-issues#9749

@marmarek

Copy link
Copy Markdown
Member

See CI logs, it wants black -l80

@marmarek

Copy link
Copy Markdown
Member

Other than that, looks okay

Signed-off-by: Alexander Paetzelt <git@techge.de>
@techge techge force-pushed the techge-2606-fix-error-msg branch from c8d4aa4 to 2d1eaf6 Compare June 19, 2026 15:15
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.42%. Comparing base (32a14bb) to head (2d1eaf6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
vmupdate/vmupdate.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   71.95%   71.42%   -0.53%     
==========================================
  Files          12       12              
  Lines        1330     1344      +14     
==========================================
+ Hits          957      960       +3     
- Misses        373      384      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qubes-vm-update --targets does not work as expected

3 participants