Skip to content

Improve output of qvm-vm-update for not-to-update vms #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techge wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve output of qvm-vm-update for not-to-update vms #216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53af339
Add a more concise error message for empty update targets
techge Jun 18, 2026
d1ce2a2
Add per vm notifications if skipped
techge Jun 18, 2026
2d1eaf6
Fix linting (black -l80)
techge Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion vmupdate/vmupdate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ def main(args=None, app=qubesadmin.Qubes()):

if not targets:
if not args.quiet:
print("No qube selected for update")
print(
"No qube eligible for update. Try --force-update to ensure ",
"all qubes are checked for new updates.",
)
return EXIT.OK_NO_UPDATES if args.signal_no_updates else EXIT.OK

admin = [target for target in targets if target.klass == "AdminVM"]
Expand Down Expand Up @@ -336,6 +339,11 @@ def select_targets(targets, args) -> Set[qubesadmin.vm.QubesVM]:
skip_update = False

if skip_update or prohibit_start:
if not args.quiet:
print(
"Skipped {}. Marked to skip updates or start prohibited",
vm.name,
)
continue

# there are updates available => select
Expand All @@ -346,10 +354,23 @@ def select_targets(targets, args) -> Set[qubesadmin.vm.QubesVM]:
# update vm only if there are updates available
# and that's not true at this point => skip
if args.update_if_available:
if not args.quiet:
print(
"Skipped {}. No updates available or not recently ",
"checked for updates.",
vm.name,
)
continue

if is_stale(vm, expiration_period=args.update_if_stale):
selected.add(vm)
else:
if not args.quiet:
print(
"Skipped {}. No updates available or last check still ",
"within stale period.",
vm.name,
)

return selected

Expand Down