Add missing includes and for_allP imports#20
Merged
qaphla merged 3 commits intoREPROSEC:mainfrom Jun 13, 2025
schaafjs:main
Merged
Add missing includes and for_allP imports#20qaphla merged 3 commits intoREPROSEC:mainfrom schaafjs:main
qaphla merged 3 commits intoREPROSEC:mainfrom
schaafjs:main
Conversation
Contributor
|
Looks like although GitHub allows me to change your branch via the website (to merge the branch Right now the CI will fail because you need to update the file |
Contributor
Author
|
I couldn't figure the merging out and have updated the lock file directly instead. |
TWal
approved these changes
Jun 13, 2025
Contributor
TWal
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
I will let @qaphla or @fabian-hk review and merge since I didn't write any code in this repo.
qaphla
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/label lib/communication) in the Makefile toDY_INCLUDE_DIRS.for_allPis now part of F* itself, the containing module also needs to be imported (fromFStar.List.Tot.Base) in all the places where it is used:DY.NSLP.Invariants.fstDY.OnlineA.Invariants.fstDY.OnlineS.Invariants.fst