Skip to content

[RL-Kernel] Productionize linear_logp telemetry#27

Open
inaniloquentee wants to merge 9 commits into
rlk-mainfrom
feature/issue20-linear-logp-telemetry-phase2
Open

[RL-Kernel] Productionize linear_logp telemetry#27
inaniloquentee wants to merge 9 commits into
rlk-mainfrom
feature/issue20-linear-logp-telemetry-phase2

Conversation

@inaniloquentee

Copy link
Copy Markdown
Collaborator

Closes #20.

Depends on #17, #18, and #19. #16 is already merged; this branch was built from the refreshed rlk-main and then stacked on the Phase 1 heads.

Summary

  • route Megatron actor selected-logprob replay through the Phase 1 RL-Kernel operator adapter without direct production rl_engine imports
  • add linear_logp support matrix, fallback/runtime metadata, operator timing counters, and optional CUDA memory-probe metrics
  • preserve native materialized-logits fallback for disabled/unsupported cases including entropy, CP, top-p replay, missing ops, and TP interface mismatch
  • document the linear_logp controls, support matrix, and telemetry surface

Validation

  • py -3.13 -m compileall vime\\backends\\megatron_utils\\rl_kernel.py vime\\backends\\megatron_utils\\loss.py vime\\backends\\megatron_utils\\model.py vime\\utils\\rl_kernel.py tests\\test_rl_kernel_linear_logp_integration.py tests\\_unit_stubs.py
  • py -3.13 -m pytest tests\\test_rl_kernel_operator_adapter.py tests\\utils\\test_rl_kernel_execution.py tests\\test_rl_kernel_linear_logp_integration.py tests\\test_megatron_argument_validation.py tests\\test_cp_utils.py tests\\test_loss_cp_invariance.py -q
  • py -3.13 -m ruff check vime\\backends\\megatron_utils\\rl_kernel.py vime\\backends\\megatron_utils\\loss.py vime\\backends\\megatron_utils\\model.py vime\\utils\\rl_kernel.py tests\\test_rl_kernel_linear_logp_integration.py tests\\_unit_stubs.py

inaniloquentee and others added 9 commits July 14, 2026 21:47
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 81a31c3b-00be-4fd1-bd14-7de9b95dff51

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/issue20-linear-logp-telemetry-phase2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant