The latest MGBF by Ting Lei#5
Open
guoqing-noaa wants to merge 221 commits into
Open
Conversation
…e old cmake structure for mgbf
… and vertically varied normalization coefficients
Co-authored-by: Nate Crossette <ncrossette@ucar.edu>
…ocks (#1186) * Introduce HybridBlockChain * Add a block diagonal coupled covariance * Add common outer blocks option * different implementation for common outer blocks * Changes to new implementation of component 4D classes in oops * Introduce HybridBlockChain * trigger CI * Some updates + a fake balance block * Bugfix: different interpolator for bg/fg * an oopsie bug * Hybrid block chain: cleanup and remove fake blocks (#1131) * Introduce HybridBlockChain * Cleanup and remove fake blocks --------- Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov> * fix indentation * Bugfix for couplederrorcovariance * Another bugfix for couplederrorcovariance * Make the balance non-triangular; fix a bug * All tests passing * Consistent handling of parameters * Trigger tests: * keep localHybridGeom_ in scope long enough * Address Anna's comments * Trigger CI with updated jjtests * Updates for merge * updates for merge * remove fake balance block that was used for debugging * simplify if statement and add check for duplicated variables * trigger CI --------- Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov> Co-authored-by: Benjamin Menetrier <benjamin.menetrier@met.no> Co-authored-by: mo-joshuacolclough <joshua.colclough@metoffice.gov.uk> Co-authored-by: Nate Crossette <ncrossette@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.