The latest MGBF by Ting Lei

.gitattributes

@@ -0,0 +1,9 @@
+# Default: treat files as text and normalize to LF in the repo
+* text=auto eol=lf
+
+# (Optional) common binary types
+*.png binary
+*.jpg binary
+*.pdf binary
+*.nc  binary
+

CMakeLists.txt

@@ -128,6 +128,17 @@ else()
     message( STATUS "SABER block SPECTRALB is NOT enabled" )
 endif()
 
+if( BUILD_TESTING AND ENABLE_OFFLINE_CODECOV )
+    ## Code coverage
+    message( STATUS "Offline code coverage is enabled" )
+    set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-arcs -ftest-coverage")
+    set( CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -fprofile-arcs -ftest-coverage")
+    set( CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fprofile-arcs -ftest-coverage")
+    set( CMAKE_Fortran_LINK_FLAGS "${CMAKE_Fortran_LINK_FLAGS} -fprofile-arcs -ftest-coverage")
+else()
+    message( STATUS "Offline code coverage is not enabled" )
+endif()
+
 ## Sources
 add_subdirectory( src/saber )
 add_subdirectory( tools )
@@ -151,36 +162,25 @@ else()
 endif()
 
 if( BUILD_TESTING )
-  # Test data
-  find_package( jedi-model-data 1.0.0 QUIET )
-
-  ## Code coverage
-  if ( ENABLE_OFFLINE_CODECOV )
-      message( STATUS "Offline code coverage is enabled" )
-      set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-arcs -ftest-coverage")
-      set( CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -fprofile-arcs -ftest-coverage")
-      set( CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fprofile-arcs -ftest-coverage")
-      set( CMAKE_Fortran_LINK_FLAGS "${CMAKE_Fortran_LINK_FLAGS} -fprofile-arcs -ftest-coverage")
-  else()
-      message( STATUS "Offline code coverage is not enabled" )
-  endif()
-
-  # If test data repo found build the tests
-  if( jedi-model-data_FOUND )
-      message( STATUS "jedi-model-data found; building saber tests" )
-      add_subdirectory( test )
-  else()
-      message( STATUS "jedi-model-data not found; skipping saber tests" )
-  endif()
-
-  ## Global tests
-  ecbuild_add_test( TARGET saber_coding_norms_src
-                    TYPE SCRIPT
-                    COMMAND ${CMAKE_BINARY_DIR}/bin/${PROJECT_NAME}_cpplint.py
-                    ARGS --quiet --recursive ${CMAKE_SOURCE_DIR}/${PROJECT_NAME}/src )
+    # Test data
+    find_package( jedi-model-data 1.0.0 QUIET )
+
+    # If test data repo found build the tests
+    if( jedi-model-data_FOUND )
+        message( STATUS "jedi-model-data found; building saber tests" )
+        add_subdirectory( test )
+    else()
+        message( STATUS "jedi-model-data not found; skipping saber tests" )
+    endif()
+
+    ## Global tests
+    ecbuild_add_test( TARGET saber_coding_norms_src
+                      TYPE SCRIPT
+                      COMMAND ${CMAKE_BINARY_DIR}/bin/${PROJECT_NAME}_cpplint.py
+                      ARGS --quiet --recursive ${CMAKE_SOURCE_DIR}/${PROJECT_NAME}/src )
 endif()
 if( ENABLE_QUENCH )
-  add_subdirectory( quench )
+    add_subdirectory( quench )
 endif()
 
 ## Package Config

cmake/compiler_flags_Intel_Fortran.cmake

@@ -0,0 +1,41 @@
+# (C) Copyright 2019 UCAR
+#
+# This software is licensed under the terms of the Apache Licence Version 2.0
+# which can be obtained at http://www.apache.org/licenses/LICENSE-2.0.
+
+####################################################################
+# FLAGS COMMON TO ALL BUILD TYPES
+####################################################################
+
+####################################################################
+# RELEASE FLAGS
+####################################################################
+
+#cltorg set( CMAKE_Fortran_FLAGS_RELEASE "-O3 -ip -unroll -inline -no-heap-arrays" )
+set( CMAKE_Fortran_FLAGS_RELEASE "-O3 -ip -unroll -inline -no-heap-arrays -fpp" )
+
+####################################################################
+# DEBUG FLAGS
+####################################################################
+
+#cltorg set( CMAKE_Fortran_FLAGS_DEBUG   "-O0 -g -check bounds -traceback -warn -heap-arrays -fpe-all=0 -fpe:0 -check all" )
+set( CMAKE_Fortran_FLAGS_DEBUG   "-O0 -g -check bounds -traceback -warn -heap-arrays -fpe-all=0 -fpe:0 -check all -fpp" )
+
+####################################################################
+# BIT REPRODUCIBLE FLAGS
+####################################################################
+
+set( CMAKE_Fortran_FLAGS_BIT     "-O2 -ip -ipo -unroll -inline -no-heap-arrays" )
+
+####################################################################
+# LINK FLAGS
+####################################################################
+
+set( CMAKE_Fortran_LINK_FLAGS    "" )
+
+####################################################################
+
+# Meaning of flags
+# ----------------
+# todo
+

codex_context.md

@@ -0,0 +1,54 @@
+# codex_context.md
+
+## Scope
+- Package: saber (MGBF components)
+- Focus: memory usage and filtering paths in mgbf_lib and covariance wrappers.
+
+## Key paths
+- MGBF covariance wrapper: src/saber/mgbf/covariance/mgbf_covariance_mod.f90
+- MGBF core library: src/saber/mgbf/mgbf_lib/*.f90
+- Filtering implementation: src/saber/mgbf/mgbf_lib/mg_filtering.f90
+- Parameters: src/saber/mgbf/mgbf_lib/mg_parameter.f90
+- Internal state: src/saber/mgbf/mgbf_lib/mg_intstate.f90
+
+## Current configuration assumptions
+- l_loc = .false.
+- l_vertical_filter = .true.
+- l_mgbf_inhomogeneous = .false.
+- filtering_fast_bkg(this) is the active filter path
+- mgbf_line may be .false. in the fast-bkg flow
+
+## Memory drivers (high-level)
+- Large arrays scale with km_all (= km * n_ens), im/jm (plus halo), lm, and count of arrays.
+- Additional multiplicative factor when nscale or nvargrp > 1.
+
+## Large allocations (mgbf_lib)
+- VALL/HALL: (km_all, im+2*hx, jm+2*hy)
+- a_diff_f/a_diff_h/b_diff_f/b_diff_h: (km_all, im+2*hx, jm+2*hy)
+- paspx4d/paspy4d and ssx4d/ssy4d: (lm, im+2*hx, jm+2*hy, 2)
+- pasp3 (3x3 tensor per grid point): (3,3,im,jm,lm)
+- hss3: (im, jm, lm, 6)
+- qcols: (0:7, im, jm, lm)
+- (localization only) w1_loc..w4_loc
+- (setup only; can be scoped) weig_var: (km_all, im+2*hx, jm+2*hy, gm)
+
+## filtering_fast_bkg usage
+Used arrays in filtering_fast_bkg:
+- paspx4d, paspy4d, ssx4d, ssy4d
+- pasp1, ss1 (vertical filter)
+- VALL, HALL
+
+Not used by filtering_fast_bkg:
+- vpasp2, hss2, dixs, diys
+- vpasp3, hss3, qcols, dixs3, diys3, dizs3
+- ss3
+- pasp2/pasp3 only needed for radial/line paths outside fast-bkg
+
+## Notes on mgbf_covariance_mod multiply
+- work_mgbf is a full 3D buffer; work2d_mgbf is a packed 2D buffer.
+- work_mgbf2 was removed by user; ensure no leftover deallocate or references.
+
+## Cleanup candidates
+- Consider guarding allocation of line-operator arrays when only filtering_fast_bkg is used.
+- Consider scoping weig_var allocation to def_mg_weights and deallocating after use.
+- Add deallocation of mg_parameter allocatables (ixm/jym/nxy/im0/jm0/Fimax/Fjmax/FimaxL/FjmaxL/zofis/isofz) if reinit happens.