Open
Conversation
Owner
|
Hey! Awesome work! I do want to stay backwards compatible with v3 somehow. |
Author
|
There you go. I tried the second solution with a sync shell command. The version is cached in M.version after the first call, so helm version is only executed once per session. |
Ramilito
reviewed
Apr 8, 2026
| ft = "k8s_yaml", | ||
| syntax = "yaml", | ||
| args = { "get", "manifest", name }, | ||
| args = { "get", "manifest", name, "-n", ns }, |
Owner
There was a problem hiding this comment.
Don't we want the namespace here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm list: drop the-aflag removed in Helm 4helm status: drop--show-desc, removed in helm/helm#13444; default status output still includes the release description.helm get manifest: pass-n <namespace>so the correct release is used when the same name exists in several namespaces.Details
This PR adds Helm v4 compatibility and fixes a Lua error triggered when fetching releases:
Helm v4 deleted
-a/--allflag from thelistcommand:An upstream PR (helm/helm#31828) aims to reintroduce it for backward compatibility, but it hasn't been merged yet.
Note on breaking changes:
This update changes how kubectl.nvim behaves with Helm v3: superseded, uninstalled, pending-install, and pending-upgrade releases will no longer be displayed in the list.
To maintain the previous behavior across both versions, we could use explicit flags: --pending --deployed --failed --superseded --uninstalled --uninstalling. Let me know if you'd like me to update the PR to maintain full backward compatibility.