Skip to content

Helm 4 compatibility #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ramilito merged 4 commits into from
Apr 20, 2026
Merged

Helm 4 compatibility #762

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
338c144
fix: remove '-a' flag for Helm v4 compatibility
tsacha Mar 29, 2026
67e1530
fix: remove '--show-desc' flag for Helm v4 compatibility
tsacha Mar 29, 2026
5f7c49d
fix: specify namespace in 'helm get manifest'
tsacha Mar 29, 2026
93e512e
fix: Helm v3 retrocompatibility
tsacha Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions lua/kubectl/resources/helm/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ local M = {
display_name = "Helm",
ft = "k8s_helm",
cmd = "helm",
url = { "ls", "-a", "-A", "--output", "json" },
url = {},
version = nil,
hints = {
{ key = "<Plug>(kubectl.kill)", desc = "uninstall" },
{ key = "<Plug>(kubectl.values)", desc = "values" },
Expand All @@ -29,6 +30,16 @@ local M = {
},
}

local function get_version()
if M.version then
return M.version
end

local result = commands.shell_command("helm", { "version", "--template='{{.Version}}'" })
M.version = tonumber(result:match("v(%d+)")) or 3
return M.version
end

local function add_namespace(args, ns)
if ns then
if ns == "All" then
Expand All @@ -41,14 +52,16 @@ local function add_namespace(args, ns)
return args
end

local function get_args()
local function get_args(version)
local ns_filter = state.getNamespace()
local args = add_namespace({ "ls", "-a", "--output", "json" }, ns_filter)
local base = version < 4 and { "ls", "-a", "--output", "json" } or { "ls", "--output", "json" }
local args = add_namespace(base, ns_filter)
return args
end

function M.View(cancellationToken)
M.definition.url = get_args()
M.definition.version = get_version()
M.definition.url = get_args(M.definition.version)
local builder = manager.get_or_create(M.definition.resource)
builder.definition = M.definition
builder.buf_nr, builder.win_nr = buffers.buffer(M.definition.ft, builder.resource)
Expand Down Expand Up @@ -85,12 +98,16 @@ function M.Draw(cancellationToken)
end

function M.Desc(name, ns)
local status_args = { "status", name, "-n", ns }
if get_version() < 4 then
table.insert(status_args, "--show-desc")
end
local def = {
resource = M.definition.resource .. "_desc",
display_name = M.definition.resource .. " | " .. name .. " | " .. ns,
ft = "k8s_desc",
syntax = "yaml",
args = { "status", name, "-n", ns, "--show-desc" },
args = status_args,
}

local builder = manager.get_or_create(def.resource)
Expand All @@ -114,7 +131,7 @@ function M.Yaml(name, ns)
display_name = M.definition.resource .. " | " .. name .. " | " .. ns,
ft = "k8s_yaml",
syntax = "yaml",
args = { "get", "manifest", name },
args = { "get", "manifest", name, "-n", ns },
Comment thread
Ramilito marked this conversation as resolved.
}

local builder = manager.get_or_create(def.resource)
Expand Down
Loading