Conversation
|
@spencer516 yeah for sure |
|
I've made a fair stab at bringing over the svg commands for constructing an arc ⛵. I've added commands classes because argument length was probably a bit lazy. Disappointingly it looks like the SVG and Canvas specs for Arc are completely different. It looks like the Canvas one is more basic and will need some x and y rotation to match the svg spec commands we have from d3. |
|
Ah interesting. Yea, I had only briefly looked at the corresponding specs and thought they looked similar; at the second pass, yea, I see what you mean. |
There was a problem hiding this comment.
It looks a bit icky with just the one entry not having quotes.
There was a problem hiding this comment.
Well technically you have 2 entries without quotes and 4 with. It might look better this way:
activeState: {
x: 0,
y: 0,
angle: 0,
'start-angle': 0,
'inner-radius': 0,
'outer-radius': null
}
|
Needs rebase |
Is this becoming too much of a behemoth helper? :-|
Give it start/end percentages; converts to radian based range. Defaults to [0, 2*PI]
ghost
|
Rebased |
Should work once arc shape support is fully filled out.
Since two path commands may have the same number of arguments
|
|
|
😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱
|
|
That is amazing. |
|
What's blocking the merge? |
|
@fsmanuel currently needs implementing in canvas, there's some kind of extra layer we need to go from svg commands to canvas commands for arcs. |
3 participants
Begin making the pieces to construct a pie chart.
Like we did with Path interpolation, we need to lovingly borrow from D3 for constructing the path pieces for pie charts from D3 here: https://github.com/mbostock/d3/blob/master/src/svg/arc.js
@bdvholmes — is this something you're at all interested in tackling?