-
Notifications
You must be signed in to change notification settings - Fork 6
Pie chart #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spencer516
wants to merge
15
commits into
master
Choose a base branch
from
pie-chart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pie chart #5
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4443d0d
Delete Unnecessary Templates
b974228
Support Sums in e3-extent
4eca22a
Support Domain Max only
6883827
Add Arc Shape Shell
75fa072
Add Tests for e3-extent sums
8e7bb4c
Support Radian Ranges
a0c05fc
Add Pie Chart Template to Dummy App
e3763c9
Create separate classes for path commands
880d165
:squirrel: Borrow svg code from d3
e889c01
Linear interpolation produces a set of Points
bd4fa81
Arc shape uses the arc shadow type
146eed4
Attempt to migrate monotone to use new commands
1ae312c
Add title to dummy page
c36d2aa
Write SVG commands using the new syntax
0b05c4f
This arc is going places!
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import e3AnimatedChild from '../e3-animated-child'; | ||
|
|
||
| export default e3AnimatedChild.extend({ | ||
| shadowType: 'arc', | ||
| enterState: {}, | ||
| activeState: { | ||
| x: 0, | ||
| y: 0, | ||
| 'start-angle': 0, | ||
| 'angle': 0, | ||
| 'inner-radius': 0, | ||
| 'outer-radius': null | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import Ember from 'ember'; | ||
| let twoPI = 2 * Math.PI; | ||
|
|
||
| export function e3RadianRange(params, hash = {}) { | ||
| let startPercent = 'start' in hash ? hash.start : 0; | ||
| let endPercent = 'end' in hash ? hash.end : 1; | ||
| return [startPercent * twoPI, endPercent * twoPI]; | ||
| } | ||
|
|
||
| export default Ember.Helper.helper(e3RadianRange); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // gets set to move for the first command and line for all others | ||
| export function Point(x, y) { | ||
| this.type = 'point'; | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
|
|
||
| export function Move(x, y) { | ||
| this.type = 'move'; | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
|
|
||
| export function Line(x, y) { | ||
| this.type = 'line'; | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
|
|
||
| export function SmoothCurve(x2, y2, x, y) { | ||
| this.type = 'smooth-curve'; | ||
| this.x2 = x2; | ||
| this.y2 = y2; | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
|
|
||
| export function BezierCurve(x1, y1, x2, y2, x, y) { | ||
| this.type = 'bezier-curve'; | ||
| this.x1 = x1; | ||
| this.y1 = y1; | ||
| this.x2 = x2; | ||
| this.y2 = y2; | ||
| this.x = x; | ||
| this.y = y; | ||
| } | ||
|
|
||
| export function Arc(rx, ry, xAxisRotation, largeArcFlag, sweepFlag, x, y) { | ||
| this.type = 'arc'; | ||
| this.x = x; | ||
| this.y = y; | ||
| this.xAxisRotation = xAxisRotation; | ||
| this.largeArcFlag = largeArcFlag; | ||
| this.sweepFlag = sweepFlag; | ||
| this.rx = rx; | ||
| this.ry = ry; | ||
| } | ||
|
|
||
| export function Close() { | ||
| this.type = 'close'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks a bit icky with just the one entry not having quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well technically you have 2 entries without quotes and 4 with. It might look better this way: