Configurable skips#47
Open
Arc676 wants to merge 8 commits intoRealFloorIsJava:masterfrom
Arc676:configurable-skips
Open
Configurable skips#47Arc676 wants to merge 8 commits intoRealFloorIsJava:masterfrom Arc676:configurable-skips
Arc676 wants to merge 8 commits intoRealFloorIsJava:masterfrom
Arc676:configurable-skips
Conversation
Defaults to server owner Match phase skip method now takes nickname argument Follow 80 char line convention Fixed syntax error in match.js
Indicates who wants to skip Indicates how many skips required to reach majority
Checking for majority now O(n) time Prevent same user from making multiple skip requests user_can_skip_phase now takes participant argument
Collaborator
Author
|
Fixed a bug where the same user could request a skip multiple times and reach majority. |
Fixed to use new function call Added argument to comment for user_can_skip_phase
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch includes new commits compared to
Arc676:skipcountdownthat allow the server owner to customize who can skip phases.It says 13 commits to merge, but 10 are the same. Hopefully this doesn't cause any issues later. Let me know if it does.