chore(release): explicitly push git commit and tags after nx release#445
Merged
justinorringer merged 1 commit intoRedHatInsights:mainfrom Mar 12, 2026
Merged
Conversation
charlesmulder
force-pushed
the
RHCLOUD-45816
branch
from
b326ec7 to
a9f843e
Compare
charlesmulder
changed the title
charlesmulder
force-pushed
the
RHCLOUD-45816
branch
from
a9f843e to
1b1eae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After switching to the unified
npx nx releasecommand, packages were being published to npm but thechore(release): publishcommit was never pushed back to the repo. This prevented nacho-bot from creating PRs to update version field in package.json.Root Cause
The unified
nx releasecommand ignoresrelease.git.push: truein nx.json. It only pushes automatically whencreateRelease(GitHub/GitLab releases) is enabled. Since we usecreateReleaseInGitHub: false, no push ever happened — the commit existed only in the ephemeral CI environment before being discarded.This affects nx 21.5.3 (javascript-clients) and nx 22.3.3 (frontend-components) identically.
Fix
Add an explicit
git push --follow-tagsstep afternpx nx release --yes.Also manually syncs rbac (6.0.1 → 7.0.0) and host-inventory (4.1.7 → 5.0.0) package.json versions to match what was already published to npm.