Skip to content

ci: prevent script injection via github.head_ref in gendoc-docs #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Reefact merged 1 commit into from
Jul 27, 2026
+7 −1
Merged

ci: prevent script injection via github.head_ref in gendoc-docs #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/gendoc-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ jobs:
> doc/generated/gendoc/errors-diff.md

- name: Commit the regenerated catalog to this branch
env:
# github.head_ref (the PR's branch name) is controllable by the PR author, so it must never
# be expanded into the run script directly: a crafted branch name would inject shell commands.
# Route it through the environment and reference it quoted below, so the shell -- not the
# Actions template engine -- handles it as data.
HEAD_REF: ${{ github.head_ref }}
run: |
set -euo pipefail
git config user.name "github-actions[bot]"
Expand All @@ -90,4 +96,4 @@ jobs:
# Pushes made with the default GITHUB_TOKEN do not re-trigger workflows (GitHub's own loop
# guard), so this never causes another 'pull_request: synchronize' event and another run of
# this job.
git push origin HEAD:${{ github.head_ref }}
git push origin "HEAD:$HEAD_REF"