♻️ Audit and remove 18 Clippy allows in orbitdock-server#79
Merged
Conversation
--permission-prompt-tool stdio routes ALL permission decisions through the control protocol, bypassing the CLI's internal --permission-mode auto-accept logic. This caused edit tools to still require manual approval even when the session was set to acceptEdits. Fix: when permission_mode is "acceptEdits", automatically include Edit, Write, and NotebookEdit in --allowedTools so the CLI pre-approves them.
…int targets Audit and clean up existing `#[allow(clippy::...)]` directives across orbitdock-server. Removes 18 of 34 allow sites by fixing the underlying design issues Clippy was pointing at: - needless_return: removed (code was already correct) - enum_variant_names: removed (no longer triggers) - type_complexity: replaced 26-element tuple with named ActiveSessionRow struct - too_many_arguments (15 sites): introduced params structs including ApprovalPreviewContext, ToolDisplayInput, IssueContext, NormalizedEventParams, TurnSnapshotRow, WorkStateUpdate, SessionMetaEvent, ClaudeResumeParams, MissionIssueStateUpdate, CreateReviewArgs, CreateSessionArgs Remaining 16 allows are deferred to follow-up issues (#75–#78) as they require larger refactors touching protocol types and connector internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audits all 34
#[allow(clippy::...)]directives in orbitdock-server and removes 18 by fixing the underlying design issues Clippy was pointing at.Removed (18 sites):
needless_return(1) — removed, code was already correctenum_variant_names(1) — removed, no longer triggerstype_complexity(1) — replaced 26-element tuple with namedActiveSessionRowstructtoo_many_arguments(15) — introduced params structs:ApprovalPreviewInput(made public) +ApprovalPreviewContextin transition.rsToolDisplayInputin tool_display.rs (12 call sites across 9 files)IssueContextin prompt.rsNormalizedEventParamsin codex normalizationTurnSnapshotRowin usage persistenceWorkStateUpdate+SessionMetaEventin codex rollout runtimeClaudeResumeParamsin session resumeMissionIssueStateUpdatein mission control persistenceCreateReviewArgs+CreateSessionArgsin CLI commandsRemaining (16 sites) — deferred to follow-ups:
large_enum_variant(5) → ♻️ Box large enum variants in protocol types (ServerMessage, ClientMessage, etc.) #75 — protocol types with wide blast radiustoo_many_argumentsin Claude connector (5) → ♻️ Refactor Claude connector internals to reduce argument counts #76 — Arc shared state patterntoo_many_argumentsin Codex connector (4) → ♻️ Refactor Codex connector and session constructor argument counts #77 — same patterntoo_many_argumentsin Session::restore + fork handler (2) → ♻️ Refactor Session::restore and handle_fork_session argument counts #78 — persistence boundaryTest plan
make rust-cipasses (check + clippy + test + fmt)#[allow(clippy::...)]directives addedCloses #71