♻️ Refactor Claude connector internals to reduce argument counts#81
Merged
♻️ Refactor Claude connector internals to reduce argument counts#81
Conversation
Introduce ClaudeSessionConfig and ClaudeEventLoopState structs to eliminate all 5 #[allow(clippy::too_many_arguments)] in connector-claude. - ClaudeSessionConfig groups the 8 CLI spawn parameters used by ClaudeSession::new and ClaudeConnector::new - ClaudeEventLoopState groups shared refs (Arc<Mutex>) and mutable local state for the event loop pipeline, reducing dispatch_stdout_message from 15 params to 2 - Updated all 7 call sites across 6 files to use the config struct - Updated sub-handlers (handle_assistant_message, handle_result_message, etc.) to take &mut ClaudeEventLoopState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClaudeSessionConfigstruct grouping the 8 CLI spawn parameters, replacing positional args inClaudeSession::newandClaudeConnector::newClaudeEventLoopStatestruct grouping shared refs and mutable local state, reducingdispatch_stdout_messagefrom 15 params to 2#[allow(clippy::too_many_arguments)]inconnector-claudehandle_assistant_message,handle_result_message, etc.) to use the state structTest plan
make rust-cipasses (fmt, clippy, build, tests)#[allow(clippy::too_many_arguments)]remain inconnector-claudeCloses #76