testing: cover modal, dialog, select, and dropdown behavior#370
Merged
RtlZeroMemory merged 3 commits intomainfrom Apr 14, 2026
Merged
testing: cover modal, dialog, select, and dropdown behavior#370RtlZeroMemory merged 3 commits intomainfrom
RtlZeroMemory merged 3 commits intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pdown-behavior testing: cover select and dropdown behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useModalStack(...)Families Covered
modaldialoguseModalStackselectdropdownTests Added, Rewritten, Removed
packages/core/src/app/__tests__/widgetBehavior.contracts.test.tsfor dialog escape close + focus restore, stacked modal focus restoration, select keyboard progression, and dropdown outside-click closeImplementation Bugs Fixed
Commands Run
./node_modules/.bin/tsc -b packages/core/tsconfig.json --pretty falsenode --test packages/core/dist/app/__tests__/widgetBehavior.contracts.test.js packages/core/dist/app/__tests__/widgetRenderer.integration.test.js packages/core/dist/testing/__tests__/referenceScenario.semantic.test.js packages/core/dist/widgets/__tests__/modalStack.hook.test.js packages/core/dist/widgets/__tests__/modal.focus.test.js packages/core/dist/widgets/__tests__/dropdown.position.test.js packages/core/dist/runtime/__tests__/overlayUnification.test.jsUnresolved Areas Left Explicit
Dependency Note
#369is already merged and this branch already absorbed the previously stacked select/dropdown slice#Closes 346
#Closes 345