Security: vcauth admin permission check and exception handling#1508
Open
Security: vcauth admin permission check and exception handling#1508
Conversation
- Add allowed_permissions = ['change'] to email_discordance action so only users with User change permission can trigger bulk emails - Log exceptions server-side and show a generic error message instead of exposing raw exception details (including email addresses) in the admin UI
davmlaw
force-pushed
the
security/vcauth-admin-fixes
branch
from
641bbfe to
aa5d84b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two security issues identified in the
vcauthadmin (see SACGF/variantgrid_private#3822):allowed_permissions = ['change']to theemail_discordanceaction. Without this, any staff user with Django admin access could trigger bulk summary emails regardless of their actual permissions.Test plan
changepermission — confirm "Email weekly summary" action is not availablechangepermission — confirm action works as before