Skip to content

Security: vcauth admin permission check and exception handling #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davmlaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security: vcauth admin permission check and exception handling #1508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions vcauth/user_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import logging

from django.contrib import messages
from django.contrib.auth.admin import UserAdmin

from classification.views.classification_email_view import send_summary_email_to_user

logger = logging.getLogger(__name__)


class CustomUserAdmin(UserAdmin):
def __init__(self, *args, **kwargs):
Expand All @@ -19,10 +23,12 @@ def email_discordance(self, request, queryset):
f"Email Server Issue or Emails disabled for sending {user.username} at {user.email} an email",
messages.WARNING)

except Exception as ex:
self.message_user(request, f"Error {ex} when sending {user.username} at {user.email} an email", messages.ERROR)
except Exception:
logger.exception("Failed to send summary email to %s", user.username)
self.message_user(request, f"Failed to send email to {user.username}. Check server logs.", messages.ERROR)

self.message_user(request, 'Emailed %i users' % count)

email_discordance.allowed_permissions = ['change']
email_discordance.short_description = "Email weekly summary"
actions = [email_discordance]
Loading