fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix#645
Open
Septicity wants to merge 1 commit intoSableClient:devfrom
Open
fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix#645Septicity wants to merge 1 commit intoSableClient:devfrom
Septicity wants to merge 1 commit intoSableClient:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I fixed the sticky scrolling issue by disabling the automatic timeline regroup for PMP messages, since this event repeatedly scrolled the user to the bottom of the page in encrypted rooms with many PMP messages.
However, this change did end up regressing the functionality of that fix: Albeit extremely irregularly, some PMP messages will fail to be grouped together or will otherwise not have their profile picture load.
To fix this, I've reintroduced the timeline regroup logic, but I've replaced the regroup function to a different room event that still provides a visual refresh without doing any scrolling.
As the previous PR hasn't made it to a public release yet, I'm not including a changeset, as it serves the same purpose as and would have ideally been included in the original PR.
Type of change
Checklist:
AI disclosure:
I used AI to quickly trace exactly what each event type does and format the new
room.emitline. As opposed to the Timeline event from before, the LocalEchoUpdated event should refresh the timeline without any automatic scrolling. This should make sure that PMP messages are properly regrouped automatically, and my testing confirms this.