Skip to content

fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Septicity wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −3
Open

fix: Safely re-introduce timeline regrouping for PMP messages after sticky scroll fix #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/app/features/room/message/Message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
RoomPinnedEventsEventContent,
MatrixEventEvent,
RoomEvent,
IRoomTimelineData,

Check failure on line 39 in src/app/features/room/message/Message.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'IRoomTimelineData' is defined but never used
} from '$types/matrix-sdk';
import classNames from 'classnames';
import { useAtomValue, useSetAtom } from 'jotai';
Expand Down Expand Up @@ -386,16 +386,21 @@

useEffect(() => {
const triggerTimelineRegroup = () => {
room.emit(RoomEvent.Timeline, mEvent, room, false, false, {
liveEvent: true,
} as IRoomTimelineData);
// A Local Echo update seems to trigger a visual refresh without
// scrolling the viewport.
room.emit(RoomEvent.LocalEchoUpdated, mEvent, room);
};

const onUpdate = () => {
setContentVersion((v) => v + 1);
triggerTimelineRegroup();
};

if (mEvent.getClearContent()) {
setContentVersion((v) => (v === 0 ? 1 : v));
triggerTimelineRegroup();
}

mEvent.on(MatrixEventEvent.Decrypted, onUpdate);
mEvent.on(MatrixEventEvent.Replaced, onUpdate);
return () => {
Expand Down
Loading