fix: ask response persistence lies to the engine after AddMessage fails, dropping assistant turns#877
Merged
SamSaffron merged 1 commit intoJun 28, 2026
Conversation
…ls, dropping assistant turns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
store.AddMessageerror from ask response persistence instead of reporting success after a failed assistant write.AddMessagefails and the engine redelivers the assistant throughTurnCompletedCallback, preserving the durable turn.Why this is high-value
term-llm askusesResponseCompletedCallbackto persist assistant/tool-call turns before tool execution. When that write failed transiently, ask returnednil, so the engine believed the assistant turn was already durable and omitted it from the later turn callback. That silently corrupted saved sessions by keeping tool results/metrics while dropping the assistant message that caused them. Returning the write error activates the engine's existing fallback path.Validation
go test ./cmd -run 'TestAskResponsePersistenceErrorRedeliversAssistantToTurnCallback|TestEnsureOutputTool|TestRunOutputTool' -count=1go build ./...go test ./...git diff --check