Skip to content

fix: remove dead code and fix avatar URL query param handling #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove dead code and fix avatar URL query param handling #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/renderers/svg.renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
// SVG Layout System
// src/renderers/svg.renderer.js

export function getColors() {
return {
background: '#0f172a',
cardBg: '#111827',
border: '#1f2937',

primaryText: '#f9fafb',
secondaryText: '#d1d5db',
mutedText: '#9ca3af',

success: '#22c55e',
warning: '#f59e0b',
danger: '#ef4444',
};
}
import darkTheme from '../themes/dark.theme.js';
import lightTheme from '../themes/light.theme.js';
import draculaTheme from '../themes/dracula.theme.js';
Expand Down
3 changes: 2 additions & 1 deletion src/services/github.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ async function fetchAvatarDataUri(avatarUrl) {
}

// Use GitHub CDN to request 96×96 image (keeps response small)
const resizedUrl = `${avatarUrl}&s=96`;
const separator = avatarUrl.includes('?') ? '&' : '?';
const resizedUrl = `${avatarUrl}${separator}s=96`;
const AVATAR_TIMEOUT_MS = 2000;
const MAX_SIZE_BYTES = 100 * 1024; // 100 KB safety limit

Expand Down