QA: run_qa v1.6 form + ExplicitImports

[ChrisRackauckas-Claude]

Please ignore until reviewed by @ChrisRackauckas.

Brings this repo's QA onto the SciMLTesting run_qa v1.6 form and enables ExplicitImports.

What changed

• Collapses the hand-rolled QA group (test/aqua.jl + test/explicit_imports.jl) into a single run_qa(ComplementaritySolve; ...) call in test/qa.jl; test/runtests.jl QA group now includes qa.jl.
• aqua_kwargs preserves the genuine non-broken Aqua disables: ambiguities = false (too many downstream ambiguities), persistent_tasks = false (PATHSolver precompile workload), project_extras = false, deps_compat = false.
• aqua_broken = (:piracies,) preserves the prior piracies = (; broken = true) suppression. The two flagged methods are the intentional, documented ArrayInterfaceCore.can_setindex piracy for FillArrays.AbstractFill and Zygote.OneElement in src/ComplementaritySolve.jl. Tracked in QA: Aqua piracies known-broken (intentional ArrayInterfaceCore.can_setindex piracy) #68.
• explicit_imports = true enables all six ExplicitImports checks (previously only no_implicit_imports + no_stale_explicit_imports ran).

Test-deps (test/Project.toml)

• Add SciMLTesting with [compat] SciMLTesting = "1.6".
• Drop ExplicitImports (now transitive via SciMLTesting) and Aqua (no Aqua sub-check that requires it as a direct dep is enabled — both ambiguities and piracies are off).

ExplicitImports findings

• no_implicit_imports: pass (module already uses using X: name everywhere).
• no_stale_explicit_imports: pass (no stale imports; nothing kept-for-downstream).
• all_explicit_imports_via_owners: pass.
• all_qualified_accesses_via_owners: pass.
• all_qualified_accesses_are_public: ignored-list of third-party / Base non-public names (each documented by source pkg): Base.Fix1/Fix2 (public in 1.12+); SciMLBase.ReturnCode enum members Infeasible/MaxIters/MaxTime/Success/T/Terminated and SciMLBase.NullParameters; PATHSolver MCP_*/solve_mcp; Zygote.OneElement; ArrayInterfaceCore.can_setindex; ForwardDiff.jacobian.
• all_explicit_imports_are_public: ignored-list TruncatedStacktraces.@truncate_stacktrace, FillArrays.AbstractFill, CommonSolve.init/solve/solve!.
• No findings required ei_broken; no implicit-imports mass refactor was needed.

Verification

Ran the QA group locally against released SciMLTesting 1.6.0 (Julia 1.10) via Pkg.test with GROUP=QA BACKEND_GROUP=CPU:

[ Info: Running tests for QA group
Test Summary:         | Pass  Broken  Total   Time
Complementarity Solve |    9       1     10  24.3s
     Testing ComplementaritySolve tests passed

Per-check breakdown: Aqua (Unbound type parameters / Undefined exports / Stale dependencies) pass; aqua: piracies (broken) = 1 Broken; all six ExplicitImports checks pass. 0 Fail / 0 Error.

🤖 Generated with Claude Code

[ChrisRackauckas-Claude]

Final EI ignore-sweep + compat verification (post make-public releases)

Re-verified the public-API ExplicitImports cleanup against the now-registered make-public releases: SciMLBase 3.27.0, SciMLTesting 1.7.0, CommonSolve 0.2.9, ExplicitImports 1.15.0, Aqua 0.8.16 (Pkg resolve, no dev of base libs).

Caller-migration (DiffEqBase.X -> SciMLBase.X): none needed. src/ already accesses every SciMLBase-owned name through SciMLBase (e.g. SciMLBase.NullParameters, using SciMLBase: ReturnCode, ...); there is no ext/ and no DiffEqBase qualified access anywhere in source.

Ignore-sweep: emptied both public-API ignore tuples, then ran the two checks directly with ignore=() on Julia 1.12 to enumerate what genuinely still flags. The flagged set is exactly the genuine non-public third-party survivors (no SciMLBase / CommonSolve / Base name appears -- those are now public and stay stripped), so each is restored as ALLOWED:

• all_qualified_accesses_are_public: MCP_MajorIterationLimit, MCP_MinorIterationLimit, MCP_NoProgress, MCP_Solved, MCP_TimeLimit, solve_mcp (PATHSolver); OneElement (Zygote); can_setindex (ArrayInterfaceCore); jacobian (ForwardDiff).
• all_explicit_imports_are_public: @truncate_stacktrace (TruncatedStacktraces); AbstractFill (FillArrays).
• The four structural checks (no_implicit_imports, no_stale_explicit_imports, all_*_via_owners) are clean.

Compat: bumped test/Project.toml SciMLTesting floor "1.6" -> "1.7" so CI resolves the gated release (1.7.0 gates the two public-API checks to Julia >= 1.11; a 1.6.x resolve would run them on the 1.10 LTS and spuriously flag public names).

Verification (registered releases, no dev):

Julia 1.12 (public-API checks RUN):
Quality Assurance | 9 Pass  1 Broken  10 Total   (0 Fail / 0 Error)

Julia 1.10 LTS (public-API checks SKIPPED via SciMLTesting 1.7 gating):
Quality Assurance | 7 Pass  1 Broken   8 Total   (0 Fail / 0 Error)

The 1 Broken in both is the intentional, documented :piracies (ArrayInterfaceCore.can_setindex for FillArrays.AbstractFill / Zygote.OneElement), tracked in #68. The 1.10 lane drops exactly the two public-API subtests (10 -> 8), confirming the gating.

The qa.jl public-API ignore lists are therefore not fully empty -- the 11 surviving entries are all genuine non-public third-party names and remain ALLOWED. No ei_broken was added/needed.

Please ignore until reviewed by @ChrisRackauckas.

🤖 Generated with Claude Code