Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
SimpleNonlinearSolve = "727e6d20-b764-4bd8-a329-72de5adea6c7"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
TruncatedStacktraces = "781d530d-4396-4725-bb49-402e4bee1e77"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[compat]
Expand All @@ -39,6 +38,5 @@ Polyester = "0.7.18"
PrecompileTools = "1.2.1"
SciMLBase = "2.147, 3.1"
SimpleNonlinearSolve = "2.7"
TruncatedStacktraces = "1.4"
Zygote = "0.7.5"
julia = "1.10"
2 changes: 0 additions & 2 deletions src/ComplementaritySolve.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ using Polyester: Polyester, @batch
import CommonSolve: init, solve, solve!
import ChainRulesCore as CRC
import FillArrays: AbstractFill
import TruncatedStacktraces: @truncate_stacktrace

const ∂0 = ZeroTangent()
const ∂∅ = NoTangent()
Expand All @@ -45,7 +44,6 @@ const AA3 = AbstractArray{T, 3} where {T}

const DEFAULT_NLSOLVER = SimpleNewtonRaphson()


abstract type AbstractComplementarityAlgorithm end
abstract type AbstractComplementaritySystemAlgorithm end
abstract type AbstractComplementaritySensitivityAlgorithm end
Expand Down
1 change: 0 additions & 1 deletion src/algorithms/generic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
nlsolver
end

@truncate_stacktrace NonlinearReformulation 1

function NonlinearReformulation(method::Symbol = :smooth, nlsolver = DEFAULT_NLSOLVER)
return NonlinearReformulation{method}(nlsolver)
Expand Down
1 change: 0 additions & 1 deletion src/algorithms/lcp/bokhoven_iterative.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ end

BokhovenIterativeAlgorithm() = BokhovenIterativeAlgorithm(DEFAULT_NLSOLVER)

@truncate_stacktrace BokhovenIterativeAlgorithm

## NOTE: It is a steady state problem so we could in-principle use an ODE Solver
for batched in (true, false)
Expand Down
1 change: 0 additions & 1 deletion src/algorithms/lcp/ipm.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ function InteriorPointMethod(linsolve = nothing; tolerance = 1.0f-5)
return InteriorPointMethod(linsolve, tolerance)
end

@truncate_stacktrace InteriorPointMethod

function __feasible_steplength(x, Δx, cache; dims = :)
T = eltype(x)
Expand Down
4 changes: 0 additions & 4 deletions src/problems/complementarity_problems.jl
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ for iip in (true, false)
end
end

@truncate_stacktrace LinearComplementarityProblem 1 2

const LCP = LinearComplementarityProblem

Expand Down Expand Up @@ -105,7 +104,6 @@ end
ub
end

@truncate_stacktrace MixedLinearComplementarityProblem

const MLCP = MixedLinearComplementarityProblem

Expand All @@ -123,7 +121,6 @@ end
p
end

@truncate_stacktrace NonlinearComplementarityProblem 1

const NCP = NonlinearComplementarityProblem

Expand All @@ -141,7 +138,6 @@ end
p
end

@truncate_stacktrace MixedComplementarityProblem 1

const MCP = MixedComplementarityProblem

Expand Down
1 change: 0 additions & 1 deletion src/sensitivity/lcp.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ end

LinearComplementarityAdjoint() = LinearComplementarityAdjoint(nothing)

@truncate_stacktrace LinearComplementarityAdjoint

__lcp_dims(u::AV, M) = (length(u), -1), length(u)^2
__lcp_dims(u::AM, M) = size(u), prod(size(M)[1:2])
Expand Down
1 change: 0 additions & 1 deletion src/sensitivity/mcp.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ end

MixedComplementarityAdjoint() = MixedComplementarityAdjoint(nothing)

@truncate_stacktrace MixedComplementarityAdjoint

function __fixed_vecjac_operator(f, y, p, A₁, A₂)
input, pb_f = Zygote.pullback(x -> f(x, p), y)
Expand Down
6 changes: 2 additions & 4 deletions test/Project.toml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
DiffEqBase = "2b5f629d-d688-5b77-993f-72d75c75574e"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand All @@ -17,6 +15,7 @@ OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
PATHSolver = "f5f7c340-0bb3-5c69-969a-41884d311d1b"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLSensitivity = "1ed8b502-d754-442c-8d5d-10ac956f44a1"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
SimpleNonlinearSolve = "727e6d20-b764-4bd8-a329-72de5adea6c7"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
Expand All @@ -26,13 +25,11 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[compat]
Aqua = "0.8"
BenchmarkTools = "1"
CUDA = "4, 5, 6.1"
ChainRulesCore = "1"
ComponentArrays = "0.15"
DiffEqBase = "6, 7.5"
ExplicitImports = "1"
FiniteDifferences = "0.12"
ForwardDiff = "0.10, 1"
NonlinearSolve = "1, 2, 3, 4"
Expand All @@ -43,6 +40,7 @@ OrdinaryDiffEq = "6, 7.0"
PATHSolver = "1"
SafeTestsets = "0.1"
SciMLSensitivity = "7"
SciMLTesting = "1.7"
SimpleNonlinearSolve = "0.1, 1, 2"
StableRNGs = "1"
Statistics = "1.10, 1.11"
Expand Down
9 changes: 0 additions & 9 deletions test/aqua.jl

This file was deleted.

8 changes: 0 additions & 8 deletions test/explicit_imports.jl

This file was deleted.

26 changes: 26 additions & 0 deletions test/qa.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
using SciMLTesting, ComplementaritySolve, Test

run_qa(
ComplementaritySolve;
explicit_imports = true,
aqua_kwargs = (;
ambiguities = false, # Too many ambiguities from downstream
persistent_tasks = false, # PATHSolver precompile workload triggers persistent task detection
project_extras = false,
deps_compat = false,
),
ei_kwargs = (;
all_qualified_accesses_are_public = (;
ignore = (
# PATHSolver C-API surface: no exports / no `public` declarations.
:MCP_MajorIterationLimit, :MCP_MinorIterationLimit,
:MCP_NoProgress, :MCP_Solved, :MCP_TimeLimit, :solve_mcp,
:jacobian, # ForwardDiff documented-but-not-`public` API
),
),
all_explicit_imports_are_public = (;
# FillArrays.AbstractFill is documented but neither exported nor `public`.
ignore = (:AbstractFill,),
),
),
)
7 changes: 2 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,8 @@ end

@testif TESTING_GROUP "QA" begin
@testif BACKEND_GROUP "CPU" begin
@safetestset "Aqua Quality Assurance" begin
include("aqua.jl")
end
@safetestset "Explicit Imports" begin
include("explicit_imports.jl")
@safetestset "Quality Assurance" begin
include("qa.jl")
end
end
end
Expand Down
Loading