Skip to content

Use namespaced Html class if available#131

Merged
gesinn-it-gea merged 1 commit into
SemanticMediaWiki:masterfrom
SomeMWDev:fix-html-class
Oct 31, 2025
Merged

Use namespaced Html class if available#131
gesinn-it-gea merged 1 commit into
SemanticMediaWiki:masterfrom
SomeMWDev:fix-html-class

Conversation

@SomeMWDev
Copy link
Copy Markdown
Contributor

This PR is made in reference to: #127

This PR addresses or contains:

  • Fix compatibility with MW 1.44 by using the namespaced Html class if it is available.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #127

This fixes compatibility with MW 1.44.
Issue: SemanticMediaWiki#127
@SomeMWDev
Copy link
Copy Markdown
Contributor Author

Tested on MW 1.39 and 1.45. This shouldn't break compatibility as it falls back to the non-namespaced Html class

@SomeMWDev SomeMWDev mentioned this pull request Oct 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (3725e29) to head (3a72826).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/MermaidParserFunction.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     94.05%   92.78%   -1.28%     
- Complexity       24       25       +1     
============================================
  Files             5        5              
  Lines           101       97       -4     
============================================
- Hits             95       90       -5     
- Misses            6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gesinn-it-gea gesinn-it-gea merged commit 7d4bb23 into SemanticMediaWiki:master Oct 31, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class "Html" not found

2 participants